Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto #14182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPatBoyd
reviewed
Dec 9, 2024
PPatBoyd
approved these changes
Dec 9, 2024
microsoft-github-policy-service
bot
added
Area: Component Views
New Architecture
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Dec 9, 2024
…Into (microsoft#14182) * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto * Change files * format * fix
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Dec 9, 2024
…Into (microsoft#14182) * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto * Change files * format * fix
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Dec 9, 2024
…Into (microsoft#14182) * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto * Change files * format * fix
acoates-ms
added a commit
that referenced
this pull request
Dec 10, 2024
…hildrenInto (#14187) * Add linter exception to generated headers for Office builds (#14157) * Add linter exception to generated headers for Office builds * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto (#14182) * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto * Change files * format * fix * fix --------- Co-authored-by: Sarang Gokhale <[email protected]>
acoates-ms
added a commit
that referenced
this pull request
Dec 10, 2024
…hildrenInto (#14188) * Add linter exception to generated headers for Office builds (#14157) * Add linter exception to generated headers for Office builds * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto (#14182) * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto * Change files * format * fix * change files * fix --------- Co-authored-by: Sarang Gokhale <[email protected]>
acoates-ms
added a commit
that referenced
this pull request
Dec 10, 2024
…hildrenInto (#14186) * Add linter exception to generated headers for Office builds (#14157) * Add linter exception to generated headers for Office builds * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto (#14182) * Add ability to override UpdateLayoutMetrics and VisualToMountChildrenInto * Change files * format * fix * fix --------- Co-authored-by: Sarang Gokhale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding ability for custom native components to provide a custom UpdateLayoutMetrics method, and to override VisualToMountChildrenInto.
I also did some cleanup of how override methods work to reduce the size of ComponentViews in memory.
Fixes #14172 and #14174.
Microsoft Reviewers: Open in CodeFlow