.Net: Replace stj-schema-mapper source code with M.E.AI schema generation #9807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
eiriktsarpalis
had a problem deploying
to
integration
GitHub Actions
Failure
eiriktsarpalis
commented
Nov 25, 2024
eiriktsarpalis
commented
Nov 25, 2024
dotnet/src/Connectors/Connectors.OpenAI.UnitTests/Core/OpenAIJsonSchemaTransformerTests.cs
Show resolved
Hide resolved
eiriktsarpalis
had a problem deploying
to
integration
GitHub Actions
Error
eiriktsarpalis
had a problem deploying
to
integration
GitHub Actions
Failure
eiriktsarpalis
had a problem deploying
to
integration
GitHub Actions
Failure
eiriktsarpalis
temporarily deployed
to
integration
GitHub Actions
Inactive
eiriktsarpalis
commented
Nov 25, 2024
dotnet/src/Connectors/Connectors.Google.UnitTests/Core/Gemini/GeminiFunctionTests.cs
Show resolved
Hide resolved
|
should this be tagged as fixing #9786 ?? |
after further internal discussions and careful reviews of the PR, it would only be partial, still need the additional flag, and selecting the "profile" from the flag, I'll try to stand up a PR for that. |
1 task
|
@eiriktsarpalis Thanks for creating the PR, we'll be focussed on this early next week |
|
This PR doesn't force SK consumers to update to .NET 9, so it's safe to merge it from this perspective. |
eiriktsarpalis
force-pushed
the
remove-json-schema-mapper
branch
from
88cbfc7 to
df45a59
Compare
eiriktsarpalis
had a problem deploying
to
integration
GitHub Actions
Error
eiriktsarpalis
temporarily deployed
to
integration
GitHub Actions
Inactive
baywet
reviewed
Dec 6, 2024
SergeyMenshykh
approved these changes
Dec 9, 2024
dotnet/src/Connectors/Connectors.OpenAI/Helpers/OpenAIChatResponseFormatHelper.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
force-pushed
the
remove-json-schema-mapper
branch
from
823155c to
33ebf16
Compare
eiriktsarpalis
temporarily deployed
to
integration
GitHub Actions
Inactive
markwallace-microsoft
approved these changes
Dec 10, 2024
SergeyMenshykh
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the source copied implementation from https://github.com/eiriktsarpalis/stj-schema-mapper with the equivalent component now made available through Microsoft.Extensions.AI.Abstractions.
cc @RogerBarreto @stephentoub @SergeyMenshykh