Deprecate AugmentationSequential wrapper #2396
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
|
It looks like NASA Marine Debris and VHR-10 data modules still use the deprecated wrapper? |
I prefer just removing it tbh. But I would like to verify kornia's augmentations work as expected for the detection datasets before that.
Yeah, I was planning to have the object detection datasets switch to Kornia's |
|
Gotcha, will mark this as a draft and wait on #1978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thoughts on whether we should deprecate this or just remove it? It's been deprecated since 0.4, but also we've been using it continuously since then. We're moving towards a 1.0 release in the future after which we'll need to start formally deprecating things anyway.