-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require VCPKG_FORCE_SYSTEM_BINARIES on arm64 Linux #1277
base: main
Are you sure you want to change the base?
Conversation
I would like to see lifting the lid on this area to completely eliminate See also: |
Yeah makes sense. Parsing that XML file with regex does not seem ideal to me, ha. Gave me a laugh as I was reminded of https://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags/1732454#1732454 (of course in practice it's fine considering the xml file is entirely controlled by yall) |
The XML file exists due to long Long ago before we had vcpkg binaries at all, where bootstrap-vcpkg.sh was also parsing the XML file with regex and this was done to be consistent with that. Now that all the platforms where vcpkgTools.xml had any meaning have binaries available, it doesn't really need to exist anymore. |
See also #868 |
I am experiencing something that may be related, but I am unsure (I am not too familiar with vcpkg): |
Seems different. I'm building from native arm64 Linux. |
thanks. But +1 for not requiring |
This is the basic set of changes to the tool to allow having entries in vcpkgTools.xml per-architecture.
Obviously this requires some changes to vcpkgTools.xml. This has been tested on arm64 Linux with
applied to vcpkgTools.xml.
Is there potentially interest in this? My usecase is I'd really like to use this arm64 Linux machine for development (a Mac Studio), and have it be able to download binarycache'd artifacts from our server. The problem with
FORCE_SYSTEM_BINARIES
is that it sets verison 0 in for cmake in the ABI, so it has to recompile everything. This combined with--host-triplet
lets me download the binary cache.Opening as draft because it requires parallel changes to vcpkgTools.xml, so the PR cannot be merged without a plan on how to do that.