[vcpkg-make] Misc fixes #42954
Open
[vcpkg-make] Misc fixes #42954
+34
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
the
category:port-bug
|
rtabmap failures: unrelated baseine regression (g2o/spdlog). |
dg0yt
commented
Dec 27, 2024
| @@ -65,6 +65,7 @@ function(z_vcpkg_make_determine_host_arch out_var) | |||
| elseif(DEFINED ENV{PROCESSOR_ARCHITECTURE}) | |||
| set(arch $ENV{PROCESSOR_ARCHITECTURE}) | |||
| else() | |||
| z_vcpkg_make_get_cmake_vars(#[[ LANGUAGES .... ]]) | |||
There was a problem hiding this comment.
It would be better to call it only once early in vcpkg_make_configure, after unified setup of arguments, instead of calling it immediately before use. ATM CMake is run only once, regardless of changing arguments. So the first call must have all arguments right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular: fix cross build and mingw.