-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gmime] Update to 3.2.15, use official build system #42959
Open
dg0yt
wants to merge
9
commits into
microsoft:master
Choose a base branch
from
dg0yt:gmime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+178
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mengna-Li
added
the
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
label
Dec 27, 2024
dg0yt
force-pushed
the
gmime
branch
2 times, most recently
from
December 27, 2024 08:10
02a1bca
to
9cdf25c
Compare
dg0yt
changed the title
[gmime] WIP
[gmime] Update to 3.2.15, use official build system
Dec 28, 2024
7 tasks
Thomas1664
reviewed
Dec 28, 2024
dg0yt
commented
Dec 28, 2024
dg0yt
commented
Dec 28, 2024
Comment on lines
10
to
13
{ | ||
"name": "vcpkg-cmake", | ||
"name": "gmime", | ||
"host": true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gmime host dependency is for reusing iconv-detect.h
at least for the same cmake system name. Alternatively we could add some files to the port dir. Windows, osx and linux results saved in https://gist.github.com/dg0yt/8451f384696a84ba6d2e70c475e93d0f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop maintaining the vendored build system which is incomplete even after #42898.
FTR upstream development was always on github, cf. jstedfast/gmime#119. New releases are only there.
We cannot bootstrap the buildsystem from the on-the-fly tarballs, so we must use the official release distfiles.