Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ucoro] add new port #42969

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[ucoro] add new port #42969

wants to merge 6 commits into from

Conversation

miyanyan
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to upstream the patch?

Comment on lines 31 to 36
+# generate config.cmake
+install(
+ EXPORT ucoroTargets
+ FILE ucoro-config.cmake
+ DESTINATION "share/ucoro"
+)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There should be NAMESPACE ...:: here.
  • If the CMake config isn't provided by upstream, vcpkg ask for the prefix "unofficial".
Suggested change
+# generate config.cmake
+install(
+ EXPORT ucoroTargets
+ FILE ucoro-config.cmake
+ DESTINATION "share/ucoro"
+)
+install(
+ EXPORT ucoroTargets
+ FILE unofficial-ucoro-config.cmake
+ NAMESPACE unofficial::ucoro::
+ DESTINATION "share/unofficial-ucoro"
+)

)

vcpkg_cmake_install()
vcpkg_cmake_config_fixup()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To complement the previous suggestion:

Suggested change
vcpkg_cmake_config_fixup()
vcpkg_cmake_config_fixup(PACKAGE_NAME unofficial-ucoro)

ports/ucoro/portfile.cmake Outdated Show resolved Hide resolved
ports/ucoro/vcpkg.json Show resolved Hide resolved
@miyanyan
Copy link
Contributor Author

Do you plan to upstream the patch?

yes, the author knows this so let me add the namespace ucoro::

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants