-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ucoro] add new port #42969
base: master
Are you sure you want to change the base?
[ucoro] add new port #42969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to upstream the patch?
ports/ucoro/cmake-install.patch
Outdated
+# generate config.cmake | ||
+install( | ||
+ EXPORT ucoroTargets | ||
+ FILE ucoro-config.cmake | ||
+ DESTINATION "share/ucoro" | ||
+) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There should be
NAMESPACE ...::
here. - If the CMake config isn't provided by upstream, vcpkg ask for the prefix "unofficial".
+# generate config.cmake | |
+install( | |
+ EXPORT ucoroTargets | |
+ FILE ucoro-config.cmake | |
+ DESTINATION "share/ucoro" | |
+) | |
+install( | |
+ EXPORT ucoroTargets | |
+ FILE unofficial-ucoro-config.cmake | |
+ NAMESPACE unofficial::ucoro:: | |
+ DESTINATION "share/unofficial-ucoro" | |
+) |
) | ||
|
||
vcpkg_cmake_install() | ||
vcpkg_cmake_config_fixup() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To complement the previous suggestion:
vcpkg_cmake_config_fixup() | |
vcpkg_cmake_config_fixup(PACKAGE_NAME unofficial-ucoro) |
yes, the author knows this so let me add the namespace |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.