feat: Add Node.js as script runner

microsoft · Dec 26, 2024 · 8ca89b0 · 8ca89b0
1 parent cd1d2c0
commit 8ca89b0
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 16 deletions.
diff --git a/extensions/npm/README.md b/extensions/npm/README.md
@@ -35,7 +35,7 @@ The extension fetches data from <https://registry.npmjs.org> and <https://regist
 - `npm.autoDetect` - Enable detecting scripts as tasks, the default is `on`.
 - `npm.runSilent` - Run npm script with the `--silent` option, the default is `false`.
 - `npm.packageManager` - The package manager used to install dependencies: `auto`, `npm`, `yarn`, `pnpm` or `bun`. The default is `auto`, which detects your package manager based on files in your workspace.
-- `npm.scriptRunner` - The script runner used to run the scripts: `auto`, `npm`, `yarn`, `pnpm` or `bun`. The default is `auto`, which detects your script runner based on files in your workspace.
+- `npm.scriptRunner` - The script runner used to run the scripts: `auto`, `npm`, `yarn`, `pnpm`, `bun` or `node`. The default is `auto`, which detects your script runner based on files in your workspace.
 - `npm.exclude` - Glob patterns for folders that should be excluded from automatic script detection. The pattern is matched against the **absolute path** of the package.json. For example, to exclude all test folders use '&ast;&ast;/test/&ast;&ast;'.
 - `npm.enableScriptExplorer` - Enable an explorer view for npm scripts.
 - `npm.scriptExplorerAction` - The default click action: `open` or `run`, the default is `open`.

diff --git a/extensions/npm/package.json b/extensions/npm/package.json
@@ -259,14 +259,16 @@
             "npm",
             "yarn",
             "pnpm",
-            "bun"
+            "bun",
+            "node"
           ],
           "enumDescriptions": [
             "%config.npm.scriptRunner.auto%",
             "%config.npm.scriptRunner.npm%",
             "%config.npm.scriptRunner.yarn%",
             "%config.npm.scriptRunner.pnpm%",
-            "%config.npm.scriptRunner.bun%"
+            "%config.npm.scriptRunner.bun%",
+            "%config.npm.scriptRunner.node%"
           ],
           "default": "auto",
           "description": "%config.npm.scriptRunner%"
@@ -361,18 +363,18 @@
       }
     ],
     "terminalQuickFixes": [
-        {
-          "id": "ms-vscode.npm-command",
-          "commandLineMatcher": "npm",
-          "commandExitResult": "error",
-          "outputMatcher": {
-            "anchor": "bottom",
-            "length": 8,
-            "lineMatcher": "Did you mean (?:this|one of these)\\?((?:\\n.+?npm .+ #.+)+)",
-            "offset": 2
-          }
+      {
+        "id": "ms-vscode.npm-command",
+        "commandLineMatcher": "npm",
+        "commandExitResult": "error",
+        "outputMatcher": {
+          "anchor": "bottom",
+          "length": 8,
+          "lineMatcher": "Did you mean (?:this|one of these)\\?((?:\\n.+?npm .+ #.+)+)",
+          "offset": 2
         }
-      ]
+      }
+    ]
   },
   "repository": {
     "type": "git",

diff --git a/extensions/npm/package.nls.json b/extensions/npm/package.nls.json
@@ -16,6 +16,7 @@
 	"config.npm.scriptRunner.yarn": "Use yarn as the script runner.",
 	"config.npm.scriptRunner.pnpm": "Use pnpm as the script runner.",
 	"config.npm.scriptRunner.bun": "Use bun as the script runner.",
+	"config.npm.scriptRunner.node": "Use Node.js as the script runner.",
 	"config.npm.scriptRunner.auto": "Auto-detect which script runner to use based on lock files and installed package managers.",
 	"config.npm.exclude": "Configure glob patterns for folders that should be excluded from automatic script detection.",
 	"config.npm.enableScriptExplorer": "Enable an explorer view for npm scripts when there is no top-level 'package.json' file.",

diff --git a/extensions/npm/src/tasks.ts b/extensions/npm/src/tasks.ts
@@ -342,7 +342,7 @@ export async function createScriptRunnerTask(context: ExtensionContext, script:
 	}
 	const taskName = getTaskName(script, relativePackageJson);
 	const cwd = path.dirname(packageJsonUri.fsPath);
-	const task = new Task(kind, folder, taskName, 'npm', new ShellExecution(scriptRunner, getCommandLine(folder.uri, ['run', script]), { cwd: cwd }));
+	const task = new Task(kind, folder, taskName, 'npm', new ShellExecution(scriptRunner, getCommandLine(folder.uri, [scriptRunner === 'node' ? '--run' : 'run', script]), { cwd: cwd }));
 	task.detail = scriptValue;
 
 	const lowerCaseTaskName = script.toLowerCase();
@@ -438,7 +438,7 @@ export async function startDebugging(context: ExtensionContext, scriptName: stri
 
 	commands.executeCommand(
 		'extension.js-debug.createDebuggerTerminal',
-		`${scriptRunner} run ${scriptName}`,
+		`${scriptRunner} ${scriptRunner === 'node' ? '--run' : 'run'} ${scriptName}`,
 		folder,
 		{ cwd },
 	);