-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bitmap index large size cause panic error #38815
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 982945902 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@982945902 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@982945902 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@982945902 E2e jenkins job failed, comment |
@982945902 go-sdk check failed, comment |
@982945902 cpp-unit-test check failed, comment |
like this code , index_data_size type will atomic infer as int type that not as excepted size_t, when size is large, it will overflow, so i change it to size_t.
in my case Cardinality is about 90000000, the index_data_size will outrange of int max 2,147,483,647, casue return size is very verry big like 18446744073709551615, next alloc memory will throw exception.