-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parsing of atom tags in RSS #153
base: master
Are you sure you want to change the base?
Conversation
Hi @mmcdole, would you mind giving a feedback, whether this has any chance of getting included and/or what is needed to do so? (I also noted, that the coverage bot avoids this PR...) |
@Necoro thanks for the submission. Can you provide a bit more context around the problem for me, just so I grok it. Do you often find atom tags within RSS feeds? |
@mmcdole |
…y atom is allowed as part of RSS
…e a json roundtrip
As needed per #151, I added parsing of atom tags in RSS.
This adds a mechanism to add a parser for certain extension namespaces. This is now only implemented for calling Atom from RSS. This avoids re-handling Atom in RSS by calling the Atom parser directly.
The implementation tries to be very agnostic: the RSS parser knows nothing about Atom. I played with the idea of removing the abstraction and couple them tighter, but the result was not that different -- so I settled with the nicer agnostic one.
The translation phase, of course, is not agnostic anymore, because it has to know what to put where.
Remarks:
*atom.Entry
.atom/parser.go#ParseAsExtension
), because I do not know the idea behind base and the url stack.actual
object take a JSON-detour (i.e., en- then decoded) to match theexpected
.author
andupdated
. If more are needed, they need to be added.Resolves #151