Promise map improved #1775
Open
Promise map improved #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ruminating a little bit about not support 'race', I think that should be also done. Albeit 'race' could be simply achieved by applying race() directly to the first n items to be started concurrently, it should be supported in map() to get that function "complete" regarding the support of all possible aggregations. |
|
This pull request is now in conflicts. Could you fix it @mjaix? 🙏 |
1 similar comment
|
This pull request is now in conflicts. Could you fix it @mjaix? 🙏 |
jhthorsen
reviewed
Aug 31, 2023
|
This pull request is now in conflicts. Could you fix it @mjaix? 🙏 |
|
Is this PR still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Generalized Mojo::Promise::Map to also support 'any' and 'all_settled' aggregations plus an optional delay
Motivation
Since the deprecation/removal of Mojo::IOLoop::delay, the only concurrency-limiting elegant way is to use Mojo::Promise::map.
Since I need the limiting as part of a general purpose functionality, I augmented Mojo::Promise::map to support various kinds of aggregation (all[default], any, all_settled) and an optional delay between processing the promises.
Test cases as well as a cookbook entry for Mojo::Promise::map is supplied.
References
LIST RELEVANT ISSUES, PULL REQUESTS AND FORUM DISCUSSIONS HERE