Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ringct: cleanup proveRctCLSAGSimple #9605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ringct: cleanup proveRctCLSAGSimple #9605

wants to merge 1 commit into from

Conversation

jeffro256
Copy link
Contributor

@jeffro256 jeffro256 commented Dec 8, 2024 •
edited
Loading

  1. Document parameters
  2. Document inner variables
  3. Remove dead variables
  4. Remove unnecessary allocations
  5. Rename a -> c_out

There should be absolutely no change to behavior.

0xFFFC0000
0xFFFC0000 approved these changes Dec 8, 2024
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Change makes code cleaner, and it is semantically same code.

Thanks.

iamamyth
iamamyth reviewed Dec 27, 2024
View reviewed changes
src/ringct/rctSigs.cpp Outdated Show resolved Hide resolved
@jeffro256
ringct: cleanup proveRctCLSAGSimple
79a0712 
1. Document parameters
2. Document inner variables
3. Remove dead variables
4. Remove unneseccary allocations
@jeffro256 jeffro256 force-pushed the min_clsag_prove_allocs branch from 729a9e0 to 79a0712 Compare December 27, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

@iamamyth iamamyth iamamyth approved these changes

Assignees
No one assigned
Labels
pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffro256 @iamamyth @0xFFFC0000 @selsta