ChainlinkBoundedCompositeOracle

[ElliotFriedman]

No description provided.

[ElliotFriedman]

@lyoungblood what do we want our upper and lower parameters to be for this?

[openzeppelin-code]

ChainlinkBoundedCompositeOracle

Generated at commit: 8365a3f9c7d699012b79fb56a8e28b6f7cf1e0dd

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	3 3 0 12 45 63
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[yaronvel]

weak inequity also here

[yaronvel]

it is not an unlikely scenario that one might want to set _lowerBound = _upperBound = 1, and currently it is not possible.
Currently it is not our plan, and can also easily workaround it with a 1 wei delta, but consider using <= instead of <.

[ElliotFriedman]

really?

then once the oracle reserves change, the oracle will fallback

[yaronvel]

yes, that the idea

[ElliotFriedman]

won't reserves increase over time though as LBTC is yield bearing, so the lower and upper bound being the same would mean that once the oracle updates and price increases, we use the fallback price, which isn't really intended behavior?

[yaronvel]

my mistake, it should be 8, to match redstone's PoR.
it would also work with 18, but then we might get confused with lower/upper bound configuration, as they will have to be with 18 decimals and not 8.

[ElliotFriedman]

sure, I can move to 8 decimals.

[ElliotFriedman]

then I can remove decimal normalization

[github-actions]

Compiling 4 files with Solc 0.8.19
Solc 0.8.19 finished in 9.10ms
Compiler run successful!
Script ran successfully.
Gas used: 33319663

If you wish to simulate on-chain transactions pass a RPC URL.

[anajuliabit]

LGTM