Skip to content
This repository has been archived by the owner on Nov 12, 2024. It is now read-only.

.reverse() #93

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

.reverse() #93

wants to merge 3 commits into from

Conversation

mattgperry
Copy link
Collaborator

@mattgperry mattgperry commented May 28, 2022

TODO

  • Implement commitStyles in waapi polyfill so we can use it to apply reverse finished styles.
  • Implement reverse() in internal polyfill. When animation reverses the current time is currently resolving to instant. We also need to consider a reversed animation "finished" when it passes < 0

@mattgperry mattgperry changed the title When animation finishes in reverse, apply initial styles .reverse() May 30, 2022
@mattgperry mattgperry changed the title .reverse() .reverse() May 30, 2022
@bakura10
Copy link
Collaborator

Hey @mattgperry .

Do you think this is an issue that will be solved within the next two months? We currently have a lot of issues in all our animations ending in initial state if closed before being finished (the only way to "restore" being to reload the whole page). We are selling themes so we cannot upgrade them once the theme is sold. Just having a rough idea would help us to know if we'd better turn off animation or not for now.

Thanks :)

@mattgperry
Copy link
Collaborator Author

Hopefully within the next two months, but I’m 100% sure as getting it in a testable state has meant adding commitStyles to the WAAPI polyfill we use in Jest and this hasn’t been as easy as I’d hoped. Is it not possible just to run a new animation rather than call reverse?

@bakura10
Copy link
Collaborator

The timeline is pretty long so it was convenient to just do a negative playbackRate, but thanks for the suggestion, that may actually work as well :)

@mattgperry
Copy link
Collaborator Author

Ahhh I hadn’t actually considered timeline, good point

@blazeshomida
Copy link

blazeshomida commented Aug 28, 2023

Is there any updates on this? Spent the last day trying to figure out what's been going wrong before I realized it wasn't me. 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants