This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Removed deprecated (now unsupported) rules to fix dependabot failed update (#661) #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for looking into this! I've been unable to spend time on this and glad to see that there are people on the internet who want to help out :-)) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #661. Stylelint 16 removed support for deprecated rules from 15 (https://stylelint.io/migration-guide/to-16#breaking-changes). I removed the rules to fix the error.
For reference, these rules were removed as stylelint has shifted their overall goal to "focus on writing and maintaining rules that help you avoid errors and enforce (non-stylistic) conventions" rather than fill the role of both linter and pretty printer. They recommend Prettier or this plugin that migrated the deprecated rules.
All four rules were disabled (set to null) so this likely isn't needed anyways, just throwing it out there.