Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cached dependencies and remove vendor dir #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peter279k
Copy link

Changed log

  • It's good to update the cached dependencies with composer.
  • Remove the composer.phar because this is the package manager and it should not be under the Git version control.
  • Removing the vendor folder because this folder is about the dependencies directory and generated by the composer.
    It should let this folder not be under Git version control.
  • Since the fieryprophet/php-sandbox package is deprecated. Using the corveda/php-sandbox package instead.
  • Since the Apache web document root has been changed on the latest eboraas/apache-php Docker image, using the $(pwd):/var/www/html volume path instead.
  • Giving a name (phpepl) for the Docker container during docker run --name=phpepl -p 80:80 -v $(pwd):/var/www/html -d eboraas/apache-php command running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant