Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): resolve languageID for spring-boot #5226

Closed
wants to merge 1 commit into from

Conversation

fannheyward
Copy link
Member

@fannheyward fannheyward commented Dec 18, 2024

Edit: this will change languageID for all language server, not a good way to resolve the issue. Close for now.

Related #5112. A better way is adding a languageID pattern in languageserver/extension configuration, but this needs pass through more layers, needs more works, just made this quickfix for now.

@asmodeus812 can you make a test with this PR?

Related #5028

A better way is adding a languageID pattern in languageserver/extension configuration, but this needs pass through more layers, needs more works, just made this quickfix for now.
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.37%. Comparing base (a6e54ae) to head (2dd045b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5226   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         291      291           
  Lines       27027    27032    +5     
  Branches     5607     5609    +2     
=======================================
+ Hits        26317    26322    +5     
  Misses        496      496           
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fannheyward
Copy link
Member Author

Edit: this will change languageID for all language server, not a good way to resolve the issue. Close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant