Makefile: Remove generated files before regenerating #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spawned out of conversation with @edude03 -- basically, it's hard to be sure that updates to controller-gen are working correctly, so making sure that all old files are removed before re-generating can help provide assurances that all of the new files *are* generated by it.
sharnoff
requested review from
edude03,
a team and
petuhovskiy
and removed request for
a team
sharnoff
changed the title
petuhovskiy
approved these changes
Dec 18, 2024
| @@ -83,6 +83,7 @@ help: ## Display this help. | |||
| generate: ## Generate boilerplate DeepCopy methods, manifests, and Go client | |||
| # Use uid and gid of current user to avoid mismatched permissions | |||
| set -e ; \ | |||
| rm -rf neonvm/client neonvm/apis/neonvm/v1/zz_generated.deepcopy.go | |||
There was a problem hiding this comment.
suggestion: would be nice in general have a traditional "make clean" target that drops generated and compiled things, because we already do clean ups here and there (kernel, generated files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawned out of conversation with @edude03 for #1158 — basically, it's hard to be sure that updates to controller-gen are working correctly, so making sure that all old files are removed before re-generating can help provide assurances that all files continue to be generated after a change.