Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "port" to borg remote placeholder #5792

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AiroPi
Copy link
Collaborator

@AiroPi AiroPi commented Dec 24, 2024

The current placeholder is confusing : ssh://user@host:/path is wrong (for example, ssh://[email protected]:/mnt/borg will raise an error).

It should either be ssh://user@host/path or ssh://user@host:port/path for more clarity.

@AiroPi AiroPi added the 3. to review Waiting for reviews label Dec 24, 2024
@AiroPi AiroPi requested a review from szaimen December 24, 2024 09:10
@AiroPi AiroPi self-assigned this Dec 24, 2024
@AiroPi AiroPi force-pushed the enh/noid/borg-remote-placeholder branch from f2d40c7 to 12fddf1 Compare December 24, 2024 09:11
@AiroPi AiroPi added the enhancement New feature or request label Dec 24, 2024
@szaimen szaimen added this to the next milestone Dec 24, 2024
@szaimen szaimen requested a review from timdiels December 24, 2024 09:24
Copy link
Collaborator

@docjyJ docjyJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen
Copy link
Collaborator

szaimen commented Dec 30, 2024

Thanks @AiroPi but there are some additional places where this should be fixed: https://github.com/search?q=repo%3Anextcloud%2Fall-in-one%20ssh%3A%2F%2Fuser%40host%3A%2Fpath%2Fto%2Frepo&type=code

@AiroPi
Copy link
Collaborator Author

AiroPi commented Dec 30, 2024

Oops, you're right. I will fix the url at these places asap 👍

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants