Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrelloJsonService.php #5859

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update TrelloJsonService.php #5859

wants to merge 3 commits into from

Conversation

mulles
Copy link

@mulles mulles commented May 7, 2024

Fixes the following issue: #5136 By fixing the following error when running 'php occ deck:import --system=TrelloJson'

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:136

and

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:364

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@Apfelwurm
Copy link

Can confirm this fixes the Problem also for importing with the TrelloApi System. Thanks!

Fixes the following issue: nextcloud#5136
By fixing the following error when running 'php occ deck:import --system=TrelloJson'

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:136

and 

Error: Call to a member function getUID() on string in /home/sites/site100028002/web/nextcloud.enklaave.org/apps/deck/lib/Service/Importer/Systems/TrelloJsonService.php:364


Signed-off-by: mulles <[email protected]>
@juliusknorr
Copy link
Member

/backport to stable29

@juliusknorr
Copy link
Member

/backport to stable28

@juliusknorr
Copy link
Member

/backport to stable27

@chkpnt
Copy link

chkpnt commented May 11, 2024

Can confirm this fixes the Problem also for importing with the TrelloApi System. Thanks!

I've just successfully imported a Trello-Board using TrelloApi after applying the proposed changes. Works fine. :-)

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

mulles added 2 commits May 22, 2024 10:25
removed trailing white space, I am sorry for that thx for your patience.

Signed-off-by: mulles <[email protected]>
@mulles mulles requested review from chkpnt and juliusknorr May 23, 2024 08:43
@new2f7
Copy link

new2f7 commented Jun 1, 2024

Would it be possible to get an official release soon to make it more easier for the people currently migrating from Trello to Nextcloud Deck following the monetisation of Trello?

@luka-nextcloud
Copy link
Contributor

@mulles Integration tests failed. Could you please rebase your branch?

@jessmartin
Copy link

Would love to have this working in Deck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trello JSON Import Error
9 participants