Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for number of low priority nodes in Azure Batch before raising a pool resize error #5576

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check for number of low priority nodes in Azure Batch before raising a pool resize error #5576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
157af25
Check for number of low priority nodes in Azure Batch before raising …
adamrtalbot Dec 5, 2024
f07190e
Merge branch 'master' into 4792_pool_resize_errors
adamrtalbot Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/nf-azure/src/main/nextflow/cloud/azure/batch/AzBatchService.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,8 +579,8 @@ class AzBatchService implements Closeable {
if( pool.state != BatchPoolState.ACTIVE ) {
throw new IllegalStateException("Azure Batch pool '${pool.id}' not in active state")
}
else if ( pool.resizeErrors && pool.currentDedicatedNodes==0 ) {
throw new IllegalStateException("Azure Batch pool '${pool.id}' has resize errors")
else if ( pool.resizeErrors && pool.currentDedicatedNodes==0 && pool.currentLowPriorityNodes==0 ) {
throw new IllegalStateException("Azure Batch pool '${pool.id}' has resize errors and no agents are available")
}
if( pool.taskSlotsPerNode != spec.vmType.numberOfCores ) {
throw new IllegalStateException("Azure Batch pool '${pool.id}' slots per node does not match the VM num cores (slots: ${pool.taskSlotsPerNode}, cores: ${spec.vmType.numberOfCores})")
Expand Down
Loading