Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path strip issue in which function(util.py) #1412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix path strip issue in which function(util.py) #1412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions thefuck/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def which(program):
"""Returns `program` path or `None`."""
try:
from shutil import which

return which(program)
except ImportError:
def is_exe(fpath):
Expand All @@ -62,14 +61,18 @@ def is_exe(fpath):
return program
else:
for path in os.environ["PATH"].split(os.pathsep):
path = path.strip('"')
# Strip only the whitespace by default
path = path.strip()
# Remove only the surrounding double quotes, if any
if path.startswith('"') and path.endswith('"'):
path = path[1:-1]
exe_file = os.path.join(path, program)
if is_exe(exe_file):
return exe_file

return None



def default_settings(params):
"""Adds default values to settings if it not presented.

Expand Down