Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 19187 : Specify Length function for PinotDB #19189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

piby180
Copy link
Contributor

@piby180 piby180 commented Dec 28, 2024

Describe your changes:

Fixes #19187

I worked on adding PinotDB to Python Dialect in ORM registry and replacing LEN() with LENGTH() for PinotDB

Type of change:

  • Improvement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harshach
Copy link
Collaborator

Thanks @piby180 for the PR.
@TeddyCr can you review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data profiling for PinotDB fails for STRING columns. LEN() function should be LENGTH()
2 participants