Implement graceful shutdown as per classic watchdog 0.9.4 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As outlined in openfaas/faas#873 and in released 0.9.4 of the classic watchdog. This commit dual-maintains the required changes to allow Kubernetes to remove traffic in a graceful way meaning we will not see connection refused errors and in-flight HTTP requests still get a chance to finish. Signed-off-by: Alex Ellis (VMware) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
As outlined in Watchdog: Alter graceful shutdown sequence faas#873 and
in released 0.9.4 of the classic watchdog. This commit
dual-maintains the required changes to allow Kubernetes to remove
traffic in a graceful way meaning we will not see connection
refused errors and in-flight HTTP requests still get a chance to
finish.
Also adds validation for
upstream_urlwhen inhttpmode.Closes #15
Signed-off-by: Alex Ellis (VMware) [email protected]