-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[City OFN Voucher] Fix VINE connected app settings #13016
base: master
Are you sure you want to change the base?
Conversation
Description is now hidden when the enterprise is connected to VINE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that you're hiding the description once connected, because it describes how to connect. Maybe we should have a different string for each case, eg enabled_description_html
and disabled_description_html
(this could be helpful for other connected apps too).
Also this is related to #13011
On that PR, Konrad is saying that they would prefer to not have to edit HTML, so would need separate keys for the link text and href.
So... I'm thinking it might be time to manage these strings in the DB, and give instance managers an easier way to update them (with a rich text editor). Maybe we can fit that in with this funded feature? I'll mention that on the other PR.
@RachL what do you think of David's suggestion ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I think this is fine to go ahead, and is compatible with my idea in case we do that in the future.
@rioug small fix needed: when not connected or disconnected the link is showed twice: otherwise all good 💪 back to in dev |
What? Why?
Split the description and link to VINE in two translatable string. Description is now hidden when an enterprise is connected to VINE.
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.