Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZicsrS Covergroup #367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ZicsrS Covergroup #367

wants to merge 1 commit into from

Conversation

coreyqh
Copy link
Contributor

@coreyqh coreyqh commented Dec 5, 2024

No description provided.

@davidharrishmc
Copy link
Collaborator

Does ZicsrU need mcountinhibit walking 1s?

Do we test combination of mcountiinhibit and scoutinhibit with delegation via mcounten? This could become an issue if not easy to resolve quickly.

Questa auto bins large coverpoints and doesn’t actually require 100% coverage of every element in the bin, but just some hits in the bin. This affects things like Zicsr* csr bins, which produce reports like

Coverpoint csr 100.00% 100 - Covered
covered/total bins: 64 64 -
missing/total bins: 0 64 -
% Hit: 100.00% 100 -
bin auto[0:63] 902834 1 - Covered
bin auto[64:127] 15334 1 - Covered
bin auto[128:191] 29802 1 - Covered
bin auto[192:255] 17836 1 - Covered
bin auto[256:319] 28009 1 - Covered
bin auto[320:383] 18031 1 - Covered

We need to replace these auto bins with

csr: coverpoint ins.current.insn[31:20]  {
    bins csrs = {[0:$]};
}

This affects at least ZicsrM/S/U, and is worth a review in other places.

Cp_csrw_corners will need to exclude satp or the system will hang.

csrname should include scounteren but exclude satp.

Add a cp_satp coverpoint similar to cp_scsrwalk that sets and clears every bit except the mode bit(s), which would cause the system to hang.

Cp_sstatus_sd_write

Several places bins M_mode should be called bins S_mode

Cp_sret should look at old_sstatus_spp, old_sstatus_spie, old_sstatus.sie (rather than mstatus)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants