Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output recursive #4050

Closed
wants to merge 15 commits into from
Closed

Conversation

1stBitcoinSent
Copy link

Add /r/output/ID recursive endpoint.

😁😅 many 1sts for me here so please go easy on me.

@1stBitcoinSent
Copy link
Author

😀 Hi @casey Hello @raphjaph I'm not sure how to run these checks 😅

@1stBitcoinSent
Copy link
Author

test example using output sat_ranges
1stBitcoinSent test example

thinking 🤔 it would also be interesting to be able to represent the history of sats artistically with recursive endpoint access to transactions

@1stBitcoinSent 1stBitcoinSent marked this pull request as draft November 19, 2024 06:37
@raphjaph
Copy link
Collaborator

How would inscriptions get the outpoint (other than hardcoding it)?

@1stBitcoinSent
Copy link
Author

1stBitcoinSent commented Nov 22, 2024

How would inscriptions get the outpoint (other than hardcoding it)?

Hello 😁 @raphjaph
This is my current workflow:
const getInscriptionId = () => window.location.pathname.split("/").pop();
let response = await fetch(`/r/inscription/${getInscriptionId()}`);
let inscriptionData = await response.json();
inscriptionData.output

@raphjaph
Copy link
Collaborator

This definitely needs some tests though as well.

@1stBitcoinSent
Copy link
Author

This definitely needs some tests though as well.

Hey @raphjaph 😁 Thank you for getting back to me on this 😀 is this ok?

@raphjaph raphjaph marked this pull request as ready for review December 18, 2024 21:54
@raphjaph
Copy link
Collaborator

I'm looking at this today, just added some structs and gonna figure out what exactly to return

@1stBitcoinSent
Copy link
Author

I'm looking at this today, just added some structs and gonna figure out what exactly to return

Thank you so much raph 🧡😆

```
```json
{
"address": "04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an address.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"indexed": true,
"value": 5000000000,
"inscriptions": [],
"runes": {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should find an example that includes some runes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know of an output that should never change like the genesis output?
maybe a burnt rune output? would that still show a rune amount if it was burnt?

@raphjaph
Copy link
Collaborator

raphjaph commented Dec 23, 2024

Hey, thanks for this PR but we decided to go with a slightly different approach in #4148. It was just too different to continue work here so I made a new PR. Have a look at #4148 and let me know what you think!

@raphjaph raphjaph closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants