Add /r/parents/:inscription_id/inscriptions endpoint.
#4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The examples in the docs for /r/children/.../inscription* have the full output, so I did the same here. Maybe it makes sense to shorten those examples, too? |
casey
requested changes
Dec 18, 2024
| .map(|inscription_id| { | ||
| let entry = index | ||
| .get_inscription_entry(inscription_id) | ||
| .unwrap() |
There was a problem hiding this comment.
These errors should be handled. If the result type of a map is Result<T>, then you can collect into a Result<Vec<T>>, which will return an error if any of the results is Result::Err.
|
|
||
| let satpoint = index | ||
| .get_inscription_satpoint_by_id(inscription_id) | ||
| .ok() |
There was a problem hiding this comment.
Same here, this error should be handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #3771 but for parents instead of children.