Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show video controls on click #4139

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Show video controls on click #4139

merged 3 commits into from
Dec 19, 2024

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 19, 2024 •
edited
Loading

This PR modifies inscription video previews so controls (play, pause, etc) are only visible after clicking the preview.

Since thumbnail iframes are wrapped with an <a> tag, the <a> tag will intecept any clicks, so it entirely disables video controls on thumbnails, which I think is correct.

On /inscription the preview iframe isn't wrapped with an <a>, so you can enable controls by clicking on it.

I think this is nice, since otherwise video inscriptions load with visible controls, which is not very nice looking.

raphjaph
raphjaph approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casey casey merged commit e0e8d40 into ordinals:master Dec 19, 2024
5 checks passed
@casey casey deleted the remove-video-controls branch December 19, 2024 22:49
raphjaph added a commit to raphjaph/ord that referenced this pull request Dec 23, 2024
@raphjaph
Squashed commit of the following:
1dc3c60 
commit c0a343f
Author: raphjaph <[email protected]>
Date:   Mon Dec 23 19:53:44 2024 +0100

    Amend

commit 2b91843
Author: raphjaph <[email protected]>
Date:   Mon Dec 23 19:51:29 2024 +0100

    Amend

commit 86a3486
Author: raphjaph <[email protected]>
Date:   Mon Dec 23 19:30:51 2024 +0100

    Make it /r/utxo/<OUTPOINT>

commit 34eede2
Author: raphjaph <[email protected]>
Date:   Mon Dec 23 18:40:05 2024 +0100

    Amend

commit 72b833b
Author: raphjaph <[email protected]>
Date:   Mon Dec 23 17:30:20 2024 +0100

    Amend

commit 7454269
Author: raphjaph <[email protected]>
Date:   Mon Dec 23 14:55:19 2024 +0100

    Amend

commit dbd9c23
Author: raphjaph <[email protected]>
Date:   Mon Dec 23 14:47:30 2024 +0100

    Add tests

commit 74b0500
Author: raphjaph <[email protected]>
Date:   Fri Dec 20 18:21:42 2024 -0500

    Not done yet

commit 77f536e
Merge: c81655d a0da0c1
Author: raphjaph <[email protected]>
Date:   Fri Dec 20 15:03:10 2024 -0500

    Merge branch 'master' of github.com:ordinals/ord into output_recursive

commit a0da0c1
Author: raph <[email protected]>
Date:   Fri Dec 20 20:59:06 2024 +0100

    Return `None` for assets when asset index does not exist (ordinals#4141)

commit c81655d
Merge: b2d8b20 d6dc51f
Author: raphjaph <[email protected]>
Date:   Fri Dec 20 14:32:14 2024 -0500

    Merge branch 'tweak-outputs-return' into output_recursive

commit d6dc51f
Author: raphjaph <[email protected]>
Date:   Fri Dec 20 13:52:32 2024 -0500

    Amend

commit 0e6d04f
Author: raphjaph <[email protected]>
Date:   Fri Dec 20 13:28:29 2024 -0500

    Amend

commit 7494843
Author: raphjaph <[email protected]>
Date:   Fri Dec 20 13:27:30 2024 -0500

    Amend

commit 249d908
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 20:12:28 2024 -0500

    Amend

commit 6ce7ba3
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 20:08:57 2024 -0500

    Amend

commit 9482ec1
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 20:05:22 2024 -0500

    Amend

commit 3d8554b
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 19:58:29 2024 -0500

    Fix other spots

commit eb491b2
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 19:38:13 2024 -0500

    Amend

commit e345540
Merge: fcdfe42 83d87d4
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 19:33:59 2024 -0500

    Merge branch 'master' of github.com:ordinals/ord into tweak-outputs-return

commit 83d87d4
Author: gmart7t2 <[email protected]>
Date:   Thu Dec 19 20:33:11 2024 -0400

    Create savepoints more robustly (ordinals#2365)

commit fcdfe42
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 19:15:33 2024 -0500

    Amend

commit 5beb449
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 18:59:39 2024 -0500

    Amend

commit af8a598
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 18:48:42 2024 -0500

    Return None if index does not have index

commit e0e8d40
Author: Casey Rodarmor <[email protected]>
Date:   Thu Dec 19 14:49:14 2024 -0800

    Show inscription preview video controls on click (ordinals#4139)

commit b2d8b20
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 16:06:42 2024 -0500

    Just some notes

commit f19b727
Merge: 16d72e5 f3cd664
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 14:45:33 2024 -0500

    Merge branch 'output_recursive' of github.com:1stBitcoinSent/ord into output_recursive

commit 16d72e5
Merge: fae4e8f a0a7a78
Author: raphjaph <[email protected]>
Date:   Thu Dec 19 14:45:27 2024 -0500

    Merge branch 'master' of github.com:ordinals/ord into output_recursive

commit f3cd664
Merge: fae4e8f a0a7a78
Author: 1stBitcoinSent <[email protected]>
Date:   Fri Dec 20 06:59:30 2024 +1300

    Merge branch 'master' into output_recursive

commit a0a7a78
Author: raph <[email protected]>
Date:   Thu Dec 19 18:49:19 2024 +0100

    Fix deploy for testnet3 (ordinals#4137)

commit fae4e8f
Merge: f8f1cee afe27e3
Author: raph <[email protected]>
Date:   Thu Dec 19 16:46:10 2024 +0100

    Merge branch 'master' into output_recursive

commit afe27e3
Author: raph <[email protected]>
Date:   Thu Dec 19 01:54:14 2024 +0100

    Add testnet4 (ordinals#4135)

commit f8f1cee
Merge: bb171e7 ee0281b
Author: 1stBitcoinSent <[email protected]>
Date:   Sat Dec 14 15:27:18 2024 +1300

    Merge branch 'ordinals:master' into output_recursive

commit bb171e7
Author: 1stBitcoinSent <[email protected]>
Date:   Sat Dec 14 15:22:03 2024 +1300

    #[test] output_recursive_endpoint()

commit ee0281b
Author: raph <[email protected]>
Date:   Fri Dec 13 00:56:56 2024 +0100

    Do not update index for info command (ordinals#4128)

commit 909a4c5
Author: raph <[email protected]>
Date:   Thu Dec 12 22:34:30 2024 +0100

    Enable rune burning in wallet (ordinals#4117)

commit 894c41d
Author: raph <[email protected]>
Date:   Thu Dec 12 01:07:21 2024 +0100

    Wait for wallet to load (ordinals#4095)

commit 080fcef
Author: raph <[email protected]>
Date:   Thu Dec 12 00:57:23 2024 +0100

    Improve wallet sync error messages (ordinals#4126)

commit fcfc93c
Author: raph <[email protected]>
Date:   Thu Dec 12 00:44:45 2024 +0100

    Link inscription burning documentation (ordinals#4131)

commit 439e470
Author: partialord <[email protected]>
Date:   Wed Dec 11 12:36:23 2024 -0800

    Enable redb quick-repair mode (ordinals#4084)

commit 4fa2d73
Merge: 4e2aaff b9a4e06
Author: 1stBitcoinSent <[email protected]>
Date:   Wed Dec 11 18:36:51 2024 +1300

    Merge branch 'master' into output_recursive

commit b9a4e06
Author: Casey Rodarmor <[email protected]>
Date:   Tue Dec 10 14:21:44 2024 -0800

    Bump ordinals crate and index schema versions (ordinals#4127)

commit 3177f9b
Author: Casey Rodarmor <[email protected]>
Date:   Tue Dec 10 13:56:24 2024 -0800

    Release 0.22.0 (ordinals#4125)

    - Bump version: 0.21.3 → 0.22.0
    - Update changelog
    - Update changelog contributor credits
    - Update dependencies

commit 4e2aaff
Merge: f10b69e 331501d
Author: 1stBitcoinSent <[email protected]>
Date:   Wed Dec 11 07:20:44 2024 +1300

    Merge branch 'master' into output_recursive

commit 331501d
Author: Casey Rodarmor <[email protected]>
Date:   Tue Dec 3 14:30:08 2024 -0500

    Style help text (ordinals#4118)

commit f10b69e
Merge: 3694157 5749363
Author: 1stBitcoinSent <[email protected]>
Date:   Tue Dec 3 19:54:45 2024 +1300

    Merge branch 'master' into output_recursive

commit 5749363
Author: onchainguy <[email protected]>
Date:   Sat Nov 30 00:26:17 2024 +0100

    Only burn one sat (ordinals#4063)

commit ee2c25b
Author: raph <[email protected]>
Date:   Fri Nov 29 22:39:26 2024 +0100

    Placate clippy (ordinals#4116)

commit 3694157
Merge: 974fced f150529
Author: 1stBitcoinSent <[email protected]>
Date:   Wed Nov 27 19:56:12 2024 +1300

    Merge branch 'master' into output_recursive

commit f150529
Author: Casey Rodarmor <[email protected]>
Date:   Tue Nov 26 14:31:52 2024 -0800

    Set `maxburnamount` when burning and require at least Bitcoin Core 25 (ordinals#4106)

commit 974fced
Merge: f5e988e a009a4e
Author: 1stBitcoinSent <[email protected]>
Date:   Wed Nov 27 10:12:00 2024 +1300

    Merge branch 'master' into output_recursive

commit a009a4e
Author: raph <[email protected]>
Date:   Tue Nov 26 22:09:48 2024 +0100

    Sign for inscription and output (ordinals#4027)

commit 487b8a9
Author: Casey Rodarmor <[email protected]>
Date:   Tue Nov 26 12:52:22 2024 -0800

    Test `Charm` `FromStr` implementation for exhaustiveness (ordinals#4107)

commit 482ac97
Author: Mark van den Broek <[email protected]>
Date:   Tue Nov 26 21:27:06 2024 +0100

    Add `palindrome` to `Charm::from_str` (ordinals#4104)

commit 12de46f
Author: Casey Rodarmor <[email protected]>
Date:   Tue Nov 26 12:15:15 2024 -0800

    Improve `ord wallet send` help message and rename output `outgoing` to `asset` (ordinals#4105)

commit f5e988e
Merge: 83468a7 5ac126d
Author: 1stBitcoinSent <[email protected]>
Date:   Tue Nov 26 20:51:33 2024 +1300

    Merge branch 'master' into output_recursive

commit 5ac126d
Author: raph <[email protected]>
Date:   Tue Nov 26 00:00:05 2024 +0100

    Hide teleburn address (ordinals#4093)

    * Do not display teleburn address

    * Amend

    * Amend

    * Amend

    * Amend

commit 83468a7
Merge: 76d08f0 446d485
Author: 1stBitcoinSent <[email protected]>
Date:   Sat Nov 23 14:01:49 2024 +1300

    Merge branch 'master' into output_recursive

commit 446d485
Author: Casey Rodarmor <[email protected]>
Date:   Fri Nov 22 15:46:09 2024 -0800

    DocumentiInscription URIs (ordinals#4098)

commit 53753e3
Author: raph <[email protected]>
Date:   Sat Nov 23 00:23:33 2024 +0100

    Show rune unlock height (ordinals#3580)

commit 2115bf2
Author: Casey Rodarmor <[email protected]>
Date:   Fri Nov 22 14:01:58 2024 -0800

    Add function to calculate rune unlock height (ordinals#4097)

commit 76d08f0
Merge: 72e369e 79f7c8e
Author: 1stBitcoinSent <[email protected]>
Date:   Fri Nov 22 20:37:33 2024 +1300

    Merge branch 'master' into output_recursive

commit 79f7c8e
Author: Casey Rodarmor <[email protected]>
Date:   Thu Nov 21 11:23:29 2024 -0800

    Handle errors when retrieving sat address (ordinals#4094)

commit 4695b2b
Author: Kartik, Chen <[email protected]>
Date:   Thu Nov 21 16:51:56 2024 +0800

    Add field metaprotocol to api::Inscription (ordinals#4047)

commit 6a9b3bd
Author: lifofifo <[email protected]>
Date:   Thu Nov 21 02:42:20 2024 -0600

    Show sat owner address when present (ordinals#4016)

commit ffe27e2
Author: Serg Pokrovskyy <[email protected]>
Date:   Thu Nov 21 03:01:31 2024 -0400

    Fixed error message when using sat or satpoint with batch inscribe (ordinals#4054)

commit 40ffa5a
Author: Casey Rodarmor <[email protected]>
Date:   Wed Nov 20 22:53:52 2024 -0800

    Add replicate and swap recipes (ordinals#4083)

commit 8f9c2ee
Author: Arron <[email protected]>
Date:   Thu Nov 21 14:42:14 2024 +0800

    Make build script public (ordinals#4085)

commit b0e7b20
Author: raph <[email protected]>
Date:   Wed Nov 20 23:19:00 2024 +0100

    Update `index.hbs` (ordinals#4090)

commit 72e369e
Author: 1stBitcoinSent <[email protected]>
Date:   Tue Nov 19 20:30:12 2024 +1300

    Update recursion.md

commit 4a59f7d
Merge: 91fc582 5e58508
Author: 1stBitcoinSent <[email protected]>
Date:   Mon Nov 18 05:57:25 2024 +1300

    Merge branch 'master' into output_recursive

commit 5e58508
Author: Thomas Marchand <[email protected]>
Date:   Fri Nov 15 02:56:53 2024 +0000

    Update Rust version in Dockerfile (ordinals#4078)

commit d44e0ff
Author: raph <[email protected]>
Date:   Fri Nov 15 03:39:44 2024 +0100

    Update minimum rust version to 1.79.0 (ordinals#4074)

commit 20c773c
Author: Casey Rodarmor <[email protected]>
Date:   Wed Nov 13 17:31:16 2024 -0800

    Fix sat off-by-one error in output template (ordinals#4075)

commit e2b0732
Author: raph <[email protected]>
Date:   Tue Nov 12 23:34:28 2024 +0100

    Update docs Github Action (ordinals#4069)

commit ab2f72f
Author: Casey Rodarmor <[email protected]>
Date:   Mon Nov 11 20:09:21 2024 -0800

    Pin `bitcoin` to 0.32.3 in `ordinals` crate (ordinals#4066)

commit d0d3bad
Author: Casey Rodarmor <[email protected]>
Date:   Mon Nov 11 19:53:31 2024 -0800

    Release 0.21.3 (ordinals#4059)

    - Bump version: 0.21.2 → 0.21.3
    - Update changelog
    - Update changelog contributor credits
    - Update dependencies
    - Pin `bitcoin` to 0.32.3
    - Downgrade `bip322` to 0.0.8

commit a8c9480
Author: raph <[email protected]>
Date:   Tue Nov 12 04:35:09 2024 +0100

    Allow restoring wallet with custom timestamp (ordinals#4065)

commit 8ab2aa0
Author: Casey Rodarmor <[email protected]>
Date:   Sun Nov 10 16:17:01 2024 -0800

    Add palindrome charm (ordinals#4064)

commit 9b88cd9
Author: Casey Rodarmor <[email protected]>
Date:   Sun Nov 10 15:54:10 2024 -0800

    Document split command (ordinals#4062)

commit e473e78
Author: raph <[email protected]>
Date:   Sat Nov 9 05:52:30 2024 +0100

    Get output information by address (ordinals#4056)

commit c01279c
Author: Casey Rodarmor <[email protected]>
Date:   Fri Nov 8 20:38:31 2024 -0800

    Allow including metadata when burning inscriptions (ordinals#4045)

commit 11adf7b
Author: Casey Rodarmor <[email protected]>
Date:   Fri Nov 8 16:19:18 2024 -0800

    Add assert_html function (ordinals#4058)

commit 54adcf6
Author: Casey Rodarmor <[email protected]>
Date:   Thu Nov 7 16:29:54 2024 -0800

    Identify collapsible nodes with class=collapse (ordinals#4055)

commit c525fcd
Author: raph <[email protected]>
Date:   Thu Nov 7 04:53:46 2024 +0100

    BIP322 sign file (ordinals#4026)

commit b5c7f88
Author: Casey Rodarmor <[email protected]>
Date:   Wed Nov 6 19:34:56 2024 -0800

    Collapse long strings in HTML (ordinals#4053)

commit 91fc582
Author: 1stBitcoinSent <[email protected]>
Date:   Tue Nov 5 21:04:14 2024 +1300

    Update recursion.md with output_recursive

commit fd2aa80
Author: 1stBitcoinSent <[email protected]>
Date:   Tue Nov 5 20:16:49 2024 +1300

    Update server.rs with output_recursive
@BrewTestBot BrewTestBot mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph