perform switch and case logic #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otakustay
requested changes
Oct 21, 2018
README.md
Outdated
| let testValue = 4; | ||
|
|
||
| <Switch value={testValue}> | ||
| <Case value={[1, 2]}> |
There was a problem hiding this comment.
如果testValue本身就是数组或者对象，匹配的需要写成下面这样。
<Case value={[testValue]}>...</Case>目前业务里遇到的场景数组和对象并不常见。
There was a problem hiding this comment.
准备改成：支持value和values两种，想匹配多个使用values
<Case value={testValue}>...</Case>
<Case values={[testValue]}>...</Case>
There was a problem hiding this comment.
先只保留value，不允许数组吧，我最近在思考把<Whether>和<Switch>在babel插件层面做优化的可能性，这个values很有可能会影响优化
There was a problem hiding this comment.
只保留value的话有些场景覆盖不到，babel优化的时候，values应该可以先转成多个value来解决吧
src/Switch.js
Outdated
| Switch.propTypes = { | ||
| value: PropTypes.oneOfType([PropTypes.string, PropTypes.number, PropTypes.bool]).isRequired, | ||
| children: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired, | ||
| equal: PropTypes.func |
There was a problem hiding this comment.
不是很建议提供这个属性，对于复杂的场景已经有Match可以做了，Switch应该是一个保持高度简洁的东西
There was a problem hiding this comment.
这个我也考虑过，这个和上面的testValue有些联系，如果testValue是数组和对象, 可能需要自定义的equal
There was a problem hiding this comment.
如果是数组和对象，也要求===会如何，我们强行和JS本身的switch一致的话……
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perform switch and case logic