-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filename
qualifier to pypi.
#170
Conversation
This allows the PURL to specify the specific artifact that was used. Signed-off-by: Mark Lodato <[email protected]>
format
and tag
qualifiers to pypi.filename
qualifier to pypi.
@iamwillbar friendly ping :) I think this is ready to be merged if you agree with the changes. |
Friendly ping. Any chance this can get merged? |
@pombredanne there are likely other purl types that could benefit from the |
@stevespringett you wrote:
@MarkLodato : @adaaaam and @johnmhoran just pointed to me that we have had a See purl-spec/PURL-SPECIFICATION.rst Line 457 in 33d772d
I also pondered using a more specific qualifier for PyPI, as we still have a small problem to consider with a file_name.
... with this file_name: numpy-2.1.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl ... which is for a combination of tags, as specified here: https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/ BUT if I have an installed nupmy wheel, I do not have direct access to the file_name unless I look the installed extracted wheel in site-packages, specifically in the the WHEEL metadata file, for instance at This WHEEL file has these tags:
And I would need process the package, version, and these tags to reconstruct a file_name as explained at:
@MarkLodato So to recap, I think we can use the existing Some examples of these PURLs would be:
|
1436b08
to
0f57b4c
Compare
- Use the standard `file_name` qualifier, not `filename`. - Link to the Python Packaging User Guide for filename conventions. Thanks to @pombredanne for the suggestions. Signed-off-by: Mark Lodato <[email protected]>
@pombredanne Thanks for the suggestions! Please take a look at the latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarkLodato Thanks! merging.
I also created #349 as a follow up to provide extra guidance for tools authors.
This allows the PURL to specify the exact file that was used.
Fixes #90.