Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type hint for cli_runner.invoke #5647

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

kurtatter
Copy link
Contributor

#5645

Hello! I love Flask! This is my first attempt to start participating in open source, so I'm very nervous, even though the changes I've made are insignificant. Thank you!

From testing.invoke() -> t.Any to testing.invoke() -> Result

@davidism davidism changed the base branch from main to stable November 23, 2024 00:48
@davidism
Copy link
Member

It looks like you committed as a different user than you posted as. Do you want to fix that?

@kurtatter
Copy link
Contributor Author

yes

@davidism
Copy link
Member

You can do the following:

$ git commit --amend --author 'Your Name <your email>' --no-edit
$ git push -f

@kurtatter
Copy link
Contributor Author

kurtatter commented Nov 23, 2024

Thanks a ton!

@davidism
Copy link
Member

Looks like that didn't work. Maybe you need to fix your git config locally and try again?

@kurtatter
Copy link
Contributor Author

(˶ᵔ ᵕ ᵔ˶)

@davidism davidism added this to the 3.1.1 milestone Nov 24, 2024
@davidism davidism changed the title Fix testing.invoke type hint. (#5645) fix type hint for cli_runner.invoke Nov 24, 2024
@davidism davidism merged commit f2674c5 into pallets:stable Nov 24, 2024
13 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants