Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG/TST (string dtype): fix and update tests for Stata IO #60130

Merged
merged 1 commit into from
Oct 30, 2024
Merged

BUG/TST (string dtype): fix and update tests for Stata IO #60130

merged 1 commit into from
Oct 30, 2024

Conversation

jorisvandenbossche
Copy link
Member

Fixing string dtype handling for writing to Stata (in case of missing values), and update the tests.

xref #54792

@jorisvandenbossche jorisvandenbossche added the Strings String extension data type and string data label Oct 30, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Oct 30, 2024
@mroeschke mroeschke merged commit e7d54a5 into pandas-dev:main Oct 30, 2024
52 of 55 checks passed
@mroeschke mroeschke added the IO Stata read_stata, to_stata label Oct 30, 2024
@mroeschke
Copy link
Member

Thanks @jorisvandenbossche

@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Oct 30, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e7d54a54da8a179fbde5878dfb4e6440d0cfbac8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60130: BUG/TST (string dtype): fix and update tests for Stata IO'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60130-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60130 on branch 2.3.x (BUG/TST (string dtype): fix and update tests for Stata IO)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche jorisvandenbossche deleted the string-dtype-io-stata branch October 30, 2024 19:26
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Oct 31, 2024
@jorisvandenbossche
BUG/TST (string dtype): fix and update tests for Stata IO (pandas-dev…
dd3c2a2 
…#60130)

(cherry picked from commit e7d54a5)
@jorisvandenbossche jorisvandenbossche mentioned this pull request Oct 31, 2024
Merged
@jorisvandenbossche
Copy link
Member Author

Manual backport at #60155

jorisvandenbossche added a commit that referenced this pull request Oct 31, 2024
@jorisvandenbossche
[backport 2.3.x] BUG/TST (string dtype): fix and update tests for Sta…
e620e9d 
…ta IO (#60130) (#60155)

BUG/TST (string dtype): fix and update tests for Stata IO (#60130)

(cherry picked from commit e7d54a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
IO Stata read_stata, to_stata Strings String extension data type and string data
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @mroeschke