TST (string dtype): resolve all easy xfails in pandas/tests/groupby #60314
Conversation
| def bad(x): | ||
| assert len(x.values.base) > 0 | ||
| if isinstance(x.values, np.ndarray): | ||
| assert len(x.values.base) > 0 | ||
| return "foo" | ||
|
|
||
| result = data.groupby(["A", "B"]).agg(bad) |
There was a problem hiding this comment.
To be honest, I am not entirely sure about the purpose of this test. Essentially it compares lambda x: "foo" passed to agg as a lambda vs a plain function, except for this assert in the function (but I don't think that should alter how this is executed?)
This was introduced in 71e9046
|
Thanks @jorisvandenbossche |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…andas-dev#60314) (cherry picked from commit c4a2026)
|
Manual backport -> #60317 |
There are a few remaining xfails that are harder to fix (require some investigation or probably an actual code fix, added some comments where I have a clue for the reason), but for the rest this resolves most xfails in
pandas/tests/groupbyxref #54792