This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
benchmark script: remove file name for --output argument #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
added
B0-silent
muharem
commented
Aug 11, 2023
| @@ -48,5 +48,5 @@ do | |||
| --repeat=$repeat \ | |||
| --json \ | |||
| --header=./file_header.txt \ | |||
| --output="${benchmarkOutput}/${output_file}.rs" >> $artifactsDir/${pallet}_benchmark.json | |||
| --output="${benchmarkOutput}/${output_dir}" >> $artifactsDir/${pallet}_benchmark.json | |||
There was a problem hiding this comment.
the artifacts/json file names still can collide.
I will address it later if we merge this - paritytech/substrate#14757
gilescope
approved these changes
Aug 18, 2023
joepetrowski
approved these changes
Aug 18, 2023
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RRemove the file name from the --output argument for the command that benchmarks the runtimes.
The benchmark CLI tool will automatically resolve the name if it's not provided. In cases where there are multiple instances of one pallet within a single runtime, the file name needs an instance name to avoid a collision. This is already supported by the CLI tool if the file name is omitted in the --output.
The current change to the script does not affect the name resolutions for the existing weights' files.
This change is required for this PR. - #2002