Changed LPFee to Percent type in Asset Conversion Pallet #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatricioNapoli
added
R0-silent
| @@ -291,6 +291,7 @@ parameter_types! { | |||
| pub const AllowMultiAssetPools: bool = false; | |||
| // should be non-zero if AllowMultiAssetPools is true, otherwise can be zero | |||
| pub const LiquidityWithdrawalFee: Permill = Permill::from_percent(0); | |||
| pub LiquidityPoolFee: Percent = Percent::from_rational_with_rounding(997u32, 1000u32, Rounding::NearestPrefDown).unwrap(); // 0.3% | |||
There was a problem hiding this comment.
yeah undesired, I meant (3, 1000) which is still rounded to either 0% or 1% depending on rounding rule. I probably need more accuracy for a 0.3% using Permill (there is no inbetween Percent and Permill right?) and then the fee calculations need to take this into consideration
There was a problem hiding this comment.
Yeah, it will have to be a PerMill
PatricioNapoli
commented
Aug 29, 2023
| let amount_in_with_fee = amount_in | ||
| .checked_mul(&(T::HigherPrecisionBalance::from(1000u32) - (T::LPFee::get().into()))) | ||
| .ok_or(Error::<T>::Overflow)?; | ||
| let fee_mult = T::HigherPrecisionBalance::from(T::LPFee::get() * 1u32); |
There was a problem hiding this comment.
TODO, temporal, same as below
|
The CI pipeline was cancelled due to failure one of the required jobs. |
| @@ -173,7 +173,7 @@ pub mod pallet { | |||
|
|
|||
| /// A % the liquidity providers will take of every swap. Represents 10ths of a percent. | |||
There was a problem hiding this comment.
Suggested change
| /// A % the liquidity providers will take of every swap. Represents 10ths of a percent. | |
| /// A % the liquidity providers will take of every swap. |
|
Ping @PatricioNapoli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
Changed Liquidity Pool fee in Asset Conversion pallet from a u32 to a Percent type.
TODO: Fix fee multipliers