Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construct Runtime v2 #1378
Construct Runtime v2 #1378
Changes from 62 commits
496bbac
cec8668
73327a1
40919d7
99a43cf
1467f0a
140e05f
6568852
2a70549
6a59057
9beb3ba
88fa35a
8ab5c66
977a553
c232d49
df4fc3d
88fa662
a3d9319
d5dd8ec
e2ab4f6
ed2d9e9
d1cd1a9
2df5888
51f1a70
996fefe
fc3b765
0498dc4
502fda4
e8b5371
dcc0b60
8a4b13c
1e44e9b
6660575
9aa6aaf
985faef
5be682d
aba35c6
7733d61
143ba02
0774bca
2c17eda
61fb110
19db6d7
69a49a4
dd1df58
c3c0be3
a8fd228
044d106
2f8b62c
c779b74
d1c976b
1aac057
d150a5b
7ad4fc7
d22e45b
017bd41
0aeb0f3
a5401ed
fcdb613
761cedb
e5c7f79
97a4425
29c2259
d71dbbc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkchr do you have an opinion on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Not sure this is such a great idea (ordering based on the index). But also wasn't the idea that this would be changed with the new
Poll
logic? Aka that the runtime implementor needs to explicitly state this order?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was causing a lot of issues as the user expectation would be to have everything as per the
pallet_index
. I would also imagine this to be better but please let me know your concerns.I am not aware of this. Could you please link the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the poll hook it can explicitly be set, yes. But my question was about the
on_initialize
etc that have fixed order.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that is a good point 👍
If we have poll explicit and have everything fixed up with
on_initialize
, the order ofon_initialize
shouldn't be that important anymore. By "fixed up"on_initialize
I mean that pallets should not call into other pallets in this stage if possible, to not run into race conditions that stuff is not yet setup. They should setup their own state and then inpoll
they can do whatever they need.