approval-voting: Make importing of duplicate assignment idempotent #6971
+61
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Gheorghe <[email protected]>
Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
requested review from
sandreim,
ordian and
AndreiEres
and removed request for
sandreim
eskimor
reviewed
Dec 21, 2024
| @@ -214,7 +215,14 @@ impl ApprovalEntry { | |||
| }, | |||
| }; | |||
|
|
|||
| self.tranches[idx].assignments.push((validator_index, tick_now)); | |||
| if !is_duplicate || | |||
There was a problem hiding this comment.
I am not getting the !is_duplicate part. Can you give me your line of reasoning here, that would help I think. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, approval-voting wouldn't receive duplicate assignments because approval-distribution makes sure of it, however in the situation where we restart we might receive the same assignment again and since approval-voting already persisted it we will end up inserting it twice in
ApprovalEntry.tranches.assignmentsbecause that's an array.Fix this by making sure duplicate assignments are a noop if the validator already had an assignment imported at the same tranche.