Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple typos #6975

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+9 −9
Open

fix multiple typos #6975

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7ae40b4
typo
crStiv Dec 20, 2024
2e8d420
typo
crStiv Dec 20, 2024
e4b718d
typo
crStiv Dec 20, 2024
f8f9a2a
typo
crStiv Dec 20, 2024
c27ef7d
typos
crStiv Dec 20, 2024
f1d0440
Update release-30_publish_release_draft.yml
crStiv Dec 30, 2024
f91f788
Update release-30_publish_release_draft.yml
crStiv Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/common/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ validate_stable_tag() {
}

# Prepare docker stable tag form the polkadot stable tag
# input: tag (polkaodot-stableYYMM(-X) or polkadot-stableYYMM(-X)-rcX)
# input: tag (polkadot-stableYYMM(-X) or polkadot-stableYYMM(-X)-rcX)
# output: stableYYMM(-X) or stableYYMM(-X)-rcX
prepare_docker_stable_tag() {
tag="$1"
Expand Down
6 changes: 3 additions & 3 deletions .github/scripts/release/release_lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ commit_with_message() {
git commit -a -m "$MESSAGE" || true
}

# Retun list of the runtimes filterd
# Retun list of the runtimes filtered
# input: none
# output: list of filtered runtimes
get_filtered_runtimes_list() {
Expand All @@ -52,7 +52,7 @@ set_spec_versions() {
git_show_log 'spec_version'
}

# Displays formated results of the git log command
# Displays formatted results of the git log command
# for the given pattern which needs to be found in logs
# input: pattern, count (optional, default is 10)
git_show_log() {
Expand All @@ -71,7 +71,7 @@ git_show_log() {
# 1_012_000 or 1_012_001 if SUFFIX is set
function get_spec_version() {
INPUT=$1
SUFFIX=${SUFFIX:-000} #this variable makes it possible to set a specific ruuntime version like 93826 it can be intialised as sestem variable
SUFFIX=${SUFFIX:-000} #this variable makes it possible to set a specific runtime version like 93826 it can be initialised as system variable
[[ $INPUT =~ .*([0-9]+\.[0-9]+\.[0-9]{1,2}).* ]]
VERSION="${BASH_REMATCH[1]}"
MATCH="${BASH_REMATCH[0]}"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-11_rc-automation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Release - RC automation
on:
# TODO: Activate it and delete old branches patterns, when the release process from stable is setteled
# TODO: Activate it and delete old branches patterns, when the release process from stable is settled
#push:
# branches:
# # Catches release-polkadot-v1.2.3, release-v1.2.3-rc1, etc
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-30_publish_release_draft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:

jobs:
check-synchronization:
uses: paritytech-release/sync-workflows/.github/workflows/check-syncronization.yml@main
uses: paritytech-release/sync-workflows/.github/workflows/check-synchronization.yml@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to update the pointed file:
https://github.com/paritytech-release/sync-workflows/blob/main/.github/workflows/check-syncronization.yml

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to update the pointed file: https://github.com/paritytech-release/sync-workflows/blob/main/.github/workflows/check-syncronization.yml

you want me to update the name of the file, or to revert changes with "syncroninzation" to "synchronization"

If I change the name of the pointed file, then probably there other files I dont know about that mention "check-syncronization", and it means there will be problems in code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting this single change is ok to me.

Otherwise we should try to ping some CI people to get their opinion I guess.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting this single change is ok to me.

Otherwise we should try to ping some CI people to get their opinion I guess.

made a PR with changes in the file you send here above


validate-inputs:
needs: [ check-synchronization ]
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-40_publish-deb-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: Release - Publish polakdot deb package
name: Release - Publish polkadot deb package

on:
workflow_dispatch:
inputs:
tag:
description: Current final release tag in the format polakdot-stableYYMM or polkadot-stable-YYMM-X
description: Current final release tag in the format polkadot-stableYYMM or polkadot-stable-YYMM-X
default: polkadot-stable2412
required: true
type: string
Expand All @@ -17,7 +17,7 @@ on:

jobs:
check-synchronization:
uses: paritytech-release/sync-workflows/.github/workflows/check-syncronization.yml@main
uses: paritytech-release/sync-workflows/.github/workflows/check-synchronization.yml@main

validate-inputs:
needs: [check-synchronization]
Expand Down
Loading