Add BlockNumberProvider to salary pallet config #7000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolkadotDom
changed the title
This was referenced Dec 25, 2024
gui1117
reviewed
Dec 26, 2024
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "collectives-westend-runtime" | |||
| version = "3.0.0" | |||
| version = "3.1.0" | |||
There was a problem hiding this comment.
same as the other PR, I think crate versions are handled upon release with prdoc information
| /// local moment in time (system block number) | ||
| fn equivalent_moment_in_time(local: SalaryLocalBlockNumber) -> SalaryNewBlockNumber { | ||
| let block_number = System::block_number(); | ||
| let local_duration = block_number.saturating_sub(local); |
There was a problem hiding this comment.
same maybe better to make it general if local > block_number, to be safe if this code gets copied and pasted.
| where | ||
| BC: ConvertBlockNumber<LocalBlockNumberFor<T>, NewBlockNumberFor<T, I>>, | ||
| { | ||
| fn on_runtime_upgrade() -> frame_support::weights::Weight { |
There was a problem hiding this comment.
could be better to implement some pre_upgrade and post_upgrade ensuring that Status value is some if it was some, and claimant count is same before and after the migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #3617, salary pallet is to be made async backing friendly. This PR adds the block number provider config parameter to pallet-salary.
In addition it
TODO:
Once Westend is updated I will write the migration for polkadot collectives.
@xlc