New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch weight from remote node #237

Merged

niklasad1 merged 10 commits into main from na-hacky-use-runtime-fetch-weight

Sep 5, 2022

Member

niklasad1 commented Aug 23, 2022 •

edited

Loading

Closing #12

niklasad1 added 5 commits

August 22, 2022 18:57


          get started

9c5bed1


          hack to share URL with fn solution_weight

89f6241


          mock solution

c8c5f7f


          fix nits

8e601b9


          reuse client

ff0d626

niklasad1 commented

View reviewed changes

src/chain.rs Outdated Show resolved Hide resolved

niklasad1 commented

View reviewed changes

src/chain.rs

+              use pallet_transaction_payment::RuntimeDispatchInfo;
+              use sp_core::Bytes;
+              pub static SHARED_CLIENT: OnceCell<SubxtClient> = OnceCell::new();

Member Author

niklasad1 Aug 24, 2022

this is needed because the MinerConfig trait doesn't take &self, so I had to use a global variable fine for now.

niklasad1 added 2 commits

August 24, 2022 10:58


          add some docs

0d0444e


          fix typos

dcebc38

niklasad1 commented

View reviewed changes

src/monitor.rs Outdated Show resolved Hide resolved

niklasad1 commented

View reviewed changes

src/monitor.rs Outdated Show resolved Hide resolved

niklasad1 commented

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved


          Update src/main.rs

3d3a872

niklasad1 requested a review from kianenigma

August 29, 2022 13:35

kianenigma reviewed

View reviewed changes

src/chain.rs Outdated Show resolved Hide resolved

kianenigma reviewed

View reviewed changes

src/chain.rs Outdated Show resolved Hide resolved

kianenigma reviewed

View reviewed changes

src/chain.rs Show resolved Hide resolved

kianenigma requested changes

View reviewed changes

Contributor

kianenigma left a comment

One mistake with desired_targets otherwise looks good.

niklasad1 added 2 commits

September 2, 2022 19:04


          address grumbles

df7e53d


          cargo fmt

d4f9892

niklasad1 commented

View reviewed changes

src/chain.rs

+              }
+              fn mock_votes(voters: u32, desired_targets: u16) -> Vec<(u32, u16)> {
+              	assert!(voters >= desired_targets as u32);

Member Author

niklasad1 Sep 2, 2022 •

edited

Loading

I guess this assertion must be true because all the "desired targets" be used?!

Contributor

kianenigma Sep 5, 2022

correct. Since we're using only votes1, we should have at at least enough voters to cover all targets.

kianenigma reviewed

View reviewed changes

src/chain.rs

+              				..Default::default()
+              			};
+              			assert_eq!(raw.solution.voter_count(), active_voters as usize);

Contributor

kianenigma Sep 5, 2022

As long as these pass, we're good.

kianenigma approved these changes

View reviewed changes

Contributor

kianenigma left a comment

Bueno

niklasad1 changed the title ~~hacky: fetch weight from remote node~~ fetch weight from remote node

niklasad1 merged commit 62e2124 into main

niklasad1 deleted the na-hacky-use-runtime-fetch-weight branch

September 5, 2022 16:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet