Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Added Asset Conversion swap*_credit functions #14716

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added Asset Conversion swap*_credit functions #14716

wants to merge 7 commits into from

Conversation

PatricioNapoli
Copy link
Contributor

Part of the effort of Paying XCM Execution Fees with foreign assets

This PR attempts to add swap operations that do not require an origin or destination for the funds (and thus will not mutate global state), and only operates within Imbalances, proper for usage within XCM.

  • Proper imbalances types for swap_exact and swap_for_exact
  • Implement do_swap_credit and probably transfer_credit
  • Expand the tests to use the new swap*_credit functions

@PatricioNapoli PatricioNapoli added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Aug 4, 2023
@PatricioNapoli PatricioNapoli added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Aug 9, 2023
muharem
muharem reviewed Aug 10, 2023
View reviewed changes
frame/asset-conversion/src/types.rs Outdated Show resolved Hide resolved
frame/asset-conversion/src/types.rs Outdated Show resolved Hide resolved
frame/asset-conversion/src/types.rs Outdated Show resolved Hide resolved
frame/asset-conversion/src/types.rs Outdated Show resolved Hide resolved
frame/asset-conversion/src/types.rs Outdated Show resolved Hide resolved
@muharem muharem requested a review from jsidorenko August 10, 2023 15:19
@PatricioNapoli PatricioNapoli marked this pull request as ready for review August 14, 2023 14:02
@PatricioNapoli PatricioNapoli requested review from a team August 14, 2023 14:02
@PatricioNapoli PatricioNapoli added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 14, 2023
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3435549

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@muharem muharem muharem left review comments

@gilescope gilescope Awaiting requested review from gilescope

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

@jsidorenko jsidorenko Awaiting requested review from jsidorenko

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
Security Audit (PRs) - SRLabs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatricioNapoli @paritytech-cicd-pr @muharem