Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: rewrite generate script to use cli-supported codemod configs #121

Open
wants to merge 2 commits into
base: PSG-5216-remove-deprecated-code
Choose a base branch
from

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Dec 23, 2024

What's New?

  • uses a config file instead of cli options due to the extended config file features (slightly better name normalizer and overlay)
  • uses the OpenAPI overlay specification to update struct names and codegen modifications for Go instead of jq
    • hoping this is easier to comprehend and maintain over time by others

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

…like the name normalizer output option and oapi overlay spec file…like the name normalizer output option and oapi overlay spec file

…like the name normalizer output option and oapi overlay spec file
@ctran88 ctran88 requested a review from a team December 23, 2024 21:50
@ctran88 ctran88 force-pushed the update-codegen-script branch from 71f580b to 680f8bf Compare December 23, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant