Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Estonian language support #10169

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: add Estonian language support #10169

wants to merge 6 commits into from

Conversation

tristankrass
Copy link

@tristankrass tristankrass commented Dec 25, 2024 •
edited
Loading

Adding Estonian language support for the Payload CMS.

DanRibbens
DanRibbens requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be merged until we resolve all the undefined values for sl translations.

@tristankrass
Copy link
Author

This can't be merged until we resolve all the undefined values for sl translations.

@DanRibbens Added missing Slovenian translations.

DanRibbens
DanRibbens requested changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build is still failing.
https://github.com/payloadcms/payload/actions/runs/12526676553/job/34940626950#step:4:29

Are you able to build locally?

@tristankrass
Copy link
Author

Looks like the build is still failing. payloadcms/payload/actions/runs/12526676553/job/34940626950#step:4:29

Are you able to build locally?

Running pnpm run build:all yields following result: (Everything looks like it's working)


 Tasks:    32 successful, 32 total
Cached:    0 cached, 32 total
  Time:    1m20.397s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denolfe denolfe Awaiting requested review from denolfe denolfe is a code owner

@jmikrut jmikrut Awaiting requested review from jmikrut jmikrut is a code owner

@DanRibbens DanRibbens Awaiting requested review from DanRibbens DanRibbens is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristankrass @DanRibbens