Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): reorders postcss plugins #10176

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gkennedy87
Copy link

This The plugin order in postcss.config.js was causing UI rendering issues in mobile Safari (#10135). This pull request affects the website template and the vercel website template.

Current version:

// Website template:  /templates/website/postcss.config.js
// Vercel website template: /templates/with-vercel-website/postcss.config.js

export default {
  plugins: {
    autoprefixer: {},
    tailwindcss: {},
  },
}

PostCSS was loading Autoprefixer before Tailwind and the vendor prefixes were not properly being prepended.

Fixed version (per Tailwind docs):

export default {
  plugins: {
    tailwindcss: {}, // this is first
    autoprefixer: {}, // this is second
  },
}

Tailwind needs to be included before Autoprefixer.
Fixed the plugin order which was causing UI issues in ios Safari
@gkennedy87 gkennedy87 changed the title fix/fixed-postcss-config-website-templates fix(template/website): fixed postcss.config.js plugin order Dec 26, 2024
@gkennedy87 gkennedy87 changed the title fix(template/website): fixed postcss.config.js plugin order fix(ui): fixed postcss.config.js plugin order Dec 26, 2024
@jacobsfletch jacobsfletch linked an issue Dec 26, 2024 that may be closed by this pull request
@jacobsfletch jacobsfletch changed the title fix(ui): fixed postcss.config.js plugin order fix(templates): reorders postcss plugins Dec 26, 2024
@gkennedy87
Copy link
Author

@paulpopus I see that some of the checks are failing. What needs to be fixed to pass the all green?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari iOS broken
1 participant