Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deny(missing-docs) #161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add deny(missing-docs) #161

wants to merge 1 commit into from

Conversation

Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Jun 15, 2024 •
edited
Loading

Hello,

This PR

  • force to document the crate by using clippy deny(missing_docs)

podusowski
podusowski requested changes Jun 16, 2024
View reviewed changes
Copy link
Owner

@podusowski podusowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have some comments though.

demo_web/src/main.rs Outdated Show resolved Hide resolved
walkers/src/download.rs Outdated Show resolved Hide resolved
walkers/src/tiles.rs Outdated Show resolved Hide resolved
@Its-Just-Nans Its-Just-Nans requested a review from podusowski June 16, 2024 08:51
podusowski
podusowski reviewed Jun 21, 2024
View reviewed changes
demo/src/lib.rs Outdated Show resolved Hide resolved
@Its-Just-Nans Its-Just-Nans requested a review from podusowski June 28, 2024 21:28
@Its-Just-Nans Its-Just-Nans reopened this Jul 2, 2024
@Its-Just-Nans Its-Just-Nans changed the title add custom provider add custom + docs Jul 2, 2024
@Its-Just-Nans Its-Just-Nans changed the title add custom + docs add deny(missing-docs) Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@podusowski podusowski Awaiting requested review from podusowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Its-Just-Nans @podusowski