Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix grid properties #240

Closed
wants to merge 3 commits into from
Closed

fix grid properties #240

wants to merge 3 commits into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Aug 20, 2022 •
edited
Loading

Fixes #239

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 4ee6918

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-render-to-string Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock
Copy link
Member Author

JoviDeCroock commented Apr 24, 2023 •
edited
Loading

Closing due to inactivity and the fix wasn't accepted in core

@JoviDeCroock JoviDeCroock deleted the fix-grid-properties branch April 24, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

px unit for grid gap discrepancy between preact-render-to-string and react-dom/server #218
2 participants
@JoviDeCroock @marvinhagemeister