Use a ref to track the hydrating state #4514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10k
duration
usedJSHeapSize
filter-list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many-updates
duration
usedJSHeapSize
replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
update10th1k
duration
usedJSHeapSize
|
|
Size Change: +107 B (+0.17%) Total Size: 62.1 kB
ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
set-hydrating-to-ref
branch
from
7a5e7ca to
882b7ac
Compare
JoviDeCroock
commented
Sep 28, 2024
| <Fragment> | ||
| <span>Foo</span> | ||
| </Fragment> | ||
| <div test-id="x">Hello world</div> |
There was a problem hiding this comment.
On main this prop would not be set for instance, this could however be more problematic when we re-use a VNode. Let's say these are both a <div> but with an entirely different subtree or attributes we could reuse the wrong vnode.
JoviDeCroock
force-pushed
the
set-hydrating-to-ref
branch
from
882b7ac to
b291f35
Compare
JoviDeCroock
force-pushed
the
set-hydrating-to-ref
branch
from
656edd3 to
13826a0
Compare
Thompson1985
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this change is so that we discontinue hydration as soon as a mismatch is detected. For deferred subtrees this won't be a problem but for synchronous trees it's problematic that we can have the following
If the span mismatches we'll still try to hydrate Foo which could mean missing props/... This is more a proposal in follow up from #4490
One thing I need to check is whether this opts out of hydration for a mismatched text node as that would be undesirable.
Might even be worth to do it differently to throw and use a regular render 😅