Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 15009 bug with not contains #17165

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

juri-sinitson
Copy link

Defect Fixes

Fixes the #15009 and adding unit tests for filtering.
Feel free to modify my code before merging when necessary.

@mertsincan
Your remarks in this PR are implemented.
If you're still missing something (e.g. that this PR is made for v18 branch instead of master), just let me know.
I'll do my best to avoid a long delay.

NOTE:
1. Configured jest according to https://thymikee.github.io/jest-preset-angular/docs/getting-started/installation
2. In was recommended in diverse sources to comment out the files
in `tsconfig.spec.json` to avoid conflicts with jest
- Especially the fixing the global filter `notContains`
which is the main scope of this issue.
- Improve signature
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 8:08pm
primeng-v18 ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 8:08pm

Copy link

vercel bot commented Dec 20, 2024

@juri-sinitson is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@mertsincan mertsincan self-requested a review December 25, 2024 14:27
@mehmetcetin01140 mehmetcetin01140 added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Dec 26, 2024
@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants