Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper: Rewrite Spaces section #2573

Merged
merged 6 commits into from
Dec 29, 2024
Merged

Conversation

EwoutH
Copy link
Member

@EwoutH EwoutH commented Dec 28, 2024

Rewrote the Spaces section the JOSS paper to be clearer and more concise, while trying to retain the key technical details.

Rewrote the Spaces section in paper.md to be clearer and more concise, while trying to retain the key technical details.
@EwoutH EwoutH requested a review from quaquel December 28, 2024 14:09
@quaquel
Copy link
Member

quaquel commented Dec 28, 2024

This might be a taste issue, but I think this shortening takes the shortening (which indeed is possible here) a few steps too far. Did we hear anything about how strict the 1000 word requirement is?

@EwoutH
Copy link
Member Author

EwoutH commented Dec 28, 2024

@quaquel not yet, I think they will tell us on review if it's too long.

I rewrote it slightly more extensively in d2ad692, I think I found a nice middle ground (this PR is updated).

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@quaquel
Copy link
Member

quaquel commented Dec 28, 2024

Thanks for the quick response. I have a few additional suggestions.

paper/paper.md Outdated Show resolved Hide resolved
@EwoutH EwoutH requested a review from quaquel December 28, 2024 15:35
Copy link
Member

@quaquel quaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more minor things

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@EwoutH
Copy link
Member Author

EwoutH commented Dec 28, 2024

Thanks! Would you like to make a few edits to this branch directly?

@quaquel
Copy link
Member

quaquel commented Dec 28, 2024

Thanks! Would you like to make a few edits to this branch directly?

I can do that as well, but I think we are basically there with the last few suggestions.

@EwoutH EwoutH requested a review from quaquel December 28, 2024 20:17
@EwoutH
Copy link
Member Author

EwoutH commented Dec 28, 2024

Implemented all suggestions

Copy link
Member

@quaquel quaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@EwoutH EwoutH merged commit fb94b0f into projectmesa:paper_2024 Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants